How Translate specific offset from one study to another study’s range?

Because you seemed to have ignored my previous recommendations. Here are my comments on how to write code properly. Taken from this pervious post: https://www.hahn-tech.com/ans/how-do-store-just-swinghighs-or-lows-in-variable-wo-the-0s-or-double-nans/

How to Write Code Properly:

First, a note on style. From all the examples we find in the Thinkscript language reference we find that variable names always begin with lower case letters. Methods (provided by the thinkscript language) begin with upper case letters. Following this style makes the code much easier to read. Fundamental data types for open, high, low, close and volume always start with lower case. You will find this style guide matches the majority of what is recommended for C based languages.

So if you are going to make me read your code, have the kindness to learn and follow the guidelines of real programers. One more note. This PO>= may seem trivial but it is much more readable when you place spaces between variable names and operators. Like this PO >= .

The other thing that really makes your code difficult to read are the excessive use of abbreviations:

• OscPeak
• HChtBarNo
• HOBarNoDiff
• HOBarDiff0
• FirstLocalSwHigh

If you are going to use excessive abbreviations than make sure to include copious amounts of comments to explain what each line is supposed to be doing.

When you use recursion, it is not required but makes things much more readable when you use rec in place of def. So don’t do this:

def HChtBarNo = if OscPeak == 1 then BarNumber() else HChtBarNo[1];

Do this instead:

rec HChtBarNo = if OscPeak == 1 then BarNumber() else HChtBarNo[1];

Ok, enough said about proper code styling. Look, when I started out I wrote some really terrible looking code. Really crappy stuff. And some of that crappy stuff is still around. So I understand. But I had others that were providing me bad examples. So for this forum, I want to make sure everyone that sees this stuff realizes what proper code looks like. If we don’t correct the errors, they will simply propagate.

On to the Solution

Have you been using plot statements during development to visualize what your code is doing?

Here is a section of your code, and this is shown in the first screenshot below (written correctly):

def oscillator = PriceOsc().PriceOsc;
def oscillatorPeak = oscillator >= oscillator[1] and oscillator >= oscillator[2] and oscillator >= oscillator[3] and oscillator >= oscillator[4] and oscillator >= oscillator[5] and oscillator >= oscillator[-1] and oscillator >= oscillator[-2] and oscillator >= oscillator[-3] and oscillator > oscillator[-4] and !oscillatorPeak[3] and !oscillatorPeak[2] and !oscillatorPeak[1];
rec oscillatorPeakIndex = if oscillatorPeak then BarNumber() else oscillatorPeakIndex[1];
plot oscillatorPeakOffset = BarNumber() – oscillatorPeakIndex;

Ok, so the screenshot gives you a visual so you know exactly what your code is doing. Notice for instance, this variable terminates four bars short of the end of the chart. Did you know that?

Next stage. We take a bit more of your code, patch it up to look pretty, and plot the next key value on the chart:

def oscillatorPeakOffsetZero = GetValue(oscillatorPeakOffset, 4) + 4; #Add back the Offset
#def HOTotOffset0 = oscillatorPeakOffsetZero; # this is completely redundant
plot highAtOscillatorPeak = GetValue(high, oscillatorPeakOffset);

Second screenshot shows the result. Crosshairs are aligned with a previous oscillator peak and red line shows the high when that peak occurs.

Everything is good up to this point. But it all falls to pieces after this. Mainly because you are using the GetMaxValueOffset() method and expecting to retrieve the highest high in the previous 5 bars (accounting for the oscillator peak offset). But if you read up on that method: http://toslc.thinkorswim.com/center/reference/thinkScript/Functions/Tech-Analysis/GetMaxValueOffset.html we find that it returns the number of bars since the highest value and NOT the highest value itself.

Go ahead, whip together a couple lines of code to plot that on a chart and see for yourself. You need to learn to use the plots on the charts as your troubleshooting method. Because in Thinkorswim we do not have any other way to troubleshoot our code. So learn by practice.

Like this:

declare lower;
plot test1 = GetMaxValueOffset(high, 5);

Third screenshot shows this plotted on the lowest subgraph.

Rather than provide a solution for you I will expect that you can take these trouble shooting techniques and finish the job. I would suggest you use a recursive variable to grab and hold onto the “highest high in 5 bars before oscillator peak”. Rather than trying to use these dynamic index values that gum up the works in Thinkscript language.

In closing, why on earth are you spending so much effort trying to build a divergence study from scratch, when you can easily buy mine and learn how it’s all done?